thisisnic commented on code in PR #14047:
URL: https://github.com/apache/arrow/pull/14047#discussion_r965675719
##########
r/tests/testthat/test-Array.R:
##########
@@ -532,6 +532,9 @@ test_that("Array$create() can handle data frame with custom
struct type (not inf
a <- Array$create(df, type = type)
expect_type_equal(a$type, type)
+ ## as_arrow_array respects `type` argument (ARROW-17620)
+ expect_type_equal(a, as_arrow_array(df, type = type))
Review Comment:
As we have a few other tests for the functionality of `as_arrow_array()`,
and this is testing one of the function's arguments, I think it's significant
enough to live in its own `test_that()` block. Would you mind making that
change, and moving it down (I think those tests start near line 1021 of this
file)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
