vibhatha commented on code in PR #14024:
URL: https://github.com/apache/arrow/pull/14024#discussion_r966665171
##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -643,6 +643,10 @@ Declaration Declaration::Sequence(std::vector<Declaration>
decls) {
return out;
}
+bool Declaration::IsValid(ExecFactoryRegistry* registry) const {
+ return registry->GetFactory(this->factory_name).ok() && this->options !=
nullptr;
Review Comment:
@westonpace should we do a full option verification here? I mean validate
for all the supported options?
I am not quite sure if this is an adequate verification. Since it is not
sure if doing that kind of a validation is a kind of redundant thing, I left it
for discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
