andygrove commented on code in PR #3407:
URL: https://github.com/apache/arrow-datafusion/pull/3407#discussion_r967184523
##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -516,6 +516,8 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
use arrow::datatypes::DataType::*;
use arrow::datatypes::TimeUnit;
match (lhs_type, rhs_type) {
+ (Date64, Date32) => Some(Date64),
Review Comment:
My understanding of this code is that it is finding the common type that
both lhs_type and rhs_type can safely be cast to, so any combination of
`Date32` and `Date64` can be cast to `Date64`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
