pitrou commented on code in PR #13931: URL: https://github.com/apache/arrow/pull/13931#discussion_r968572339
########## cpp/src/arrow/csv/reader.cc: ########## @@ -970,6 +972,145 @@ class StreamingReaderImpl : public ReaderMixin, std::shared_ptr<std::atomic<int64_t>> bytes_decoded_; }; +class ParallelStreamingReaderImpl Review Comment: I'm not found of all the duplication here. How about having `StreamingReaderImpl` take a buffer-async-generator instead? ########## cpp/src/arrow/csv/reader.cc: ########## @@ -970,6 +972,145 @@ class StreamingReaderImpl : public ReaderMixin, std::shared_ptr<std::atomic<int64_t>> bytes_decoded_; }; +class ParallelStreamingReaderImpl Review Comment: I'm not fond of all the duplication here. How about having `StreamingReaderImpl` take a buffer-async-generator instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
