lidavidm commented on PR #44: URL: https://github.com/apache/arrow-nanoarrow/pull/44#issuecomment-1244011751
Except for the switch-case fallthrough, the warnings I found were all mostly nits. So maybe we don't care about them. If we think it's useful, I'll also include the CMake config I used and fix the remainder of the clang lints (there are a bunch of places where it wants explicit casts), and add a test for the fallthrough, and we can iterate from there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
