HaoYang670 opened a new pull request, #2717: URL: https://github.com/apache/arrow-rs/pull/2717
Signed-off-by: remzi <1371656737...@gmail.com> # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #2715. # Rationale for this change 1. `try_binary` should not panic on unequaled array length 2. The checked ops (checked_add, checked_mul ...) is better to return Result. Because - we can return the error directly in `try_binary` and other `try_...` kernels - Different ops have different Errors (Overflow, dividebyZero) 3. Remove `math_checked_op` because it is the same as `try_binary` # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org