pitrou commented on code in PR #14129:
URL: https://github.com/apache/arrow/pull/14129#discussion_r971668782
##########
cpp/src/arrow/array/concatenate_test.cc:
##########
@@ -539,4 +539,14 @@ TEST_F(ConcatenateTest, OffsetOverflow) {
ASSERT_RAISES(Invalid, Concatenate({fake_long, fake_long}).status());
}
+TEST_F(ConcatenateTest, DictionaryConcatenateWithEmptyUint16) {
+ auto dict_type = dictionary(uint16(), utf8());
Review Comment:
Add a comment here mentioned the JIRA number?
##########
cpp/src/arrow/array/concatenate_test.cc:
##########
@@ -539,4 +539,14 @@ TEST_F(ConcatenateTest, OffsetOverflow) {
ASSERT_RAISES(Invalid, Concatenate({fake_long, fake_long}).status());
}
+TEST_F(ConcatenateTest, DictionaryConcatenateWithEmptyUint16) {
+ auto dict_type = dictionary(uint16(), utf8());
Review Comment:
Could you add a comment here mentioning the JIRA number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
