eitsupi commented on code in PR #14122: URL: https://github.com/apache/arrow/pull/14122#discussion_r971858604
########## r/tests/testthat/test-dplyr-group-by.R: ########## @@ -166,3 +166,67 @@ test_that("group_by() with namespaced functions", { tbl ) }) + +test_that("group_by() with .add", { Review Comment: My intention was not to make `.add = FALSE` explicit so that detect if the dplyr's default behavior changed, but it is unlikely that this is the case, so it seems fine to make it explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org