save-buffer commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r972349660
########## cpp/src/arrow/compute/exec/spilling_util.cc: ########## @@ -0,0 +1,483 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "spilling_util.h" +#include <mutex> + +namespace arrow +{ +namespace compute +{ + struct ArrayInfo + { + int64_t num_children; + int64_t length; + int64_t null_count; + std::shared_ptr<DataType> type; + std::array<std::shared_ptr<Buffer>, 3> bufs; + std::array<size_t, 3> sizes; + std::shared_ptr<ArrayData> dictionary; + }; + +#ifdef _WIN32 +#include "windows_compatibility.h" + + struct SpillFile::BatchInfo + { + int64_t start; + std::vector<ArrayInfo> arrays; + }; + +const FileHandle kInvalidHandle = INVALID_HANDLE_VALUE; + +static Result<FileHandle> OpenTemporaryFile() +{ + constexpr DWORD kTempFileNameSize = MAX_PATH + 1; + wchar_t tmp_name_buf[kTempFileNameSize]; + wchar_t tmp_path_buf[kTempFileNameSize]; + + DWORD ret; + ret = GetTempPath2W(kTempFileNameSize, tmp_path_buf); + if(ret > kTempFileNameSize || ret == 0) + return Status::IOError(); + if(GetTempFileNameW(tmp_path_buf, L"ARROW_TMP", 0, tmp_name_buf) == 0) + return Status::IOError(); + + HANDLE file_handle = CreateFileA( + tmp_name_buf, + GENERIC_READ | GENERIC_WRITE | FILE_APPEND_DATA, + 0, + NULL, + CREATE_ALWAYS, + FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED | FILE_FLAG_DELETE_ON_CLOSE, + NULL); + if(file_handle == INVALID_HANDLE_VALUE) + return Status::IOError("Failed to create temp file"); + return file_handle; +} + +static Status CloseTemporaryFile(FileHandle handle) +{ + if(!CloseHandle(handle)) + return Status::IOError("Failed to close temp file"); + return Status::OK(); +} + +static Status WriteBatch_PlatformSpecific(FileHandle handle, const SpillFile::BatchInfo &info) +{ + OVERLAPPED overlapped; + int64_t offset = info.start; + for(const ArrayInfo &arr : info.arrays) + { + for(size_t i = 0; i < arr.bufs.size(); i++) + { + if(info.bufs[i] != 0) + { + overlapped.Offset = static_cast<DWORD>(offset & static_cast<DWORD>(~0)); + overlapped.OffsetHigh = static_cast<DWORD>((offset >> 32) & static_cast<DWORD>(~0)); Review Comment: DWORD is a uint32 right? (isn't the story that back on MS-DOS a word was 16 bits, so WORD is uint16 and then when 32-bit systems came around they made DWORD be a double-word?) I guess I just want to make absolutely sure that I am only taking bottom 32 bits. I can probably remove the cast? I'll switch it to `~static_cast(0)` though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
