liukun4515 commented on PR #3396: URL: https://github.com/apache/arrow-datafusion/pull/3396#issuecomment-1248962110
> I meet so many issue when remove the binary type coercion which is caused from these pr #3301 #3246 For example `is TRUE`, these is a logical expr `Expr::IsTrue` but convert it to the physical binary op in https://github.com/andygrove/arrow-datafusion/blob/92b1a341aca334c54235ef65737c88037010e30b/datafusion/physical-expr/src/planner.rs#L86 > > @andygrove why not generate the logical binary op when create the `Expr::IsTrue` logical expr. cc @alamb I create the issue https://github.com/apache/arrow-datafusion/issues/3509 to support other logical expr for the typ coercion. If we can convert such expr like `istrue, isfalse,like` to `binary op` in the logical phase, we don't need to do this by adding more case in the TypeCoercion optimizer rule. I don't why we don't do this when implement the `is true, is false` in the https://github.com/apache/arrow-datafusion/pull/3301/files @andygrove , is there any optimization should be done in the logical phase with the `Expr:IsTrue`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
