viirya commented on code in PR #2740:
URL: https://github.com/apache/arrow-rs/pull/2740#discussion_r973513522
##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -570,6 +596,28 @@ macro_rules! math_dict_op {
}};
}
+/// Helper function to perform math lambda function on values from two
dictionary arrays, this
+/// version does not attempt to use SIMD explicitly (though the compiler may
auto vectorize)
+macro_rules! math_dict_checked_op {
+ ($left: expr, $right:expr, $op:expr, $value_ty:ty) => {{
+ if $left.len() != $right.len() {
+ return Err(ArrowError::ComputeError(format!(
+ "Cannot perform operation on arrays of different length ({},
{})",
+ $left.len(),
+ $right.len()
+ )));
+ }
+
+ // Safety justification: Since the inputs are valid Arrow arrays, all
values are
Review Comment:
There is one where I copied the code from. Now it is not. Can remove the
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
