emkornfield commented on code in PR #14142:
URL: https://github.com/apache/arrow/pull/14142#discussion_r974516674
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1530,7 +1680,7 @@ class TypedRecordReader : public
ColumnReaderImplBase<DType>,
int64_t ReadRecordData(int64_t num_records) {
// Conservative upper bound
const int64_t possible_num_values =
- std::max(num_records, levels_written_ - levels_position_);
+ std::max<int>(num_records, levels_written_ - levels_position_);
Review Comment:
int64_t?
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1542,7 +1692,7 @@ class TypedRecordReader : public
ColumnReaderImplBase<DType>,
} else if (this->max_def_level_ > 0) {
// No repetition levels, skip delimiting logic. Each level represents a
// null or not null entry
- records_read = std::min(levels_written_ - levels_position_, num_records);
+ records_read = std::min<int>(levels_written_ - levels_position_,
num_records);
Review Comment:
int64_t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
