westonpace commented on code in PR #14172:
URL: https://github.com/apache/arrow/pull/14172#discussion_r974729714
##########
cpp/src/arrow/compute/exec/asof_join_node_test.cc:
##########
@@ -633,6 +633,11 @@ struct BasicTest {
using AsofJoinBasicParams = std::tuple<std::function<void(BasicTest&)>,
std::string>;
+void PrintTo(const AsofJoinBasicParams& x, ::std::ostream* os) {
+ *os << "AsofJoinBasicParams: " << std::get<0>(x).target_type().name() << " -
"
+ << std::get<1>(x);
Review Comment:
```suggestion
*os << "AsofJoinBasicParams: " << std::get<1>(x);
```
I think `target_type().name()` is unlikely to add any useful information
beyond `std::get<1>(x)`. CC @rtpsw for a second opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
