rok commented on PR #13516: URL: https://github.com/apache/arrow/pull/13516#issuecomment-1251739545
> Here are some potential changes for implementing the callback API with `std::function`, which uses closures instead of a client-provided `void*`. I updated the relevant tests as well. This looks good to me! Thanks a lot @benibus ! > Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit. Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to [my fork](https://github.com/rok/arrow) in case you'd want to push more changes to this branch and avoid the UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
