Dandandan commented on code in PR #3530:
URL: https://github.com/apache/arrow-datafusion/pull/3530#discussion_r975343124
##########
datafusion/optimizer/src/limit_push_down.rs:
##########
@@ -438,6 +461,44 @@ mod test {
Ok(())
}
+ #[test]
+ fn limit_push_down_sort() -> Result<()> {
+ let table_scan = test_table_scan()?;
+
+ let plan = LogicalPlanBuilder::from(table_scan)
+ .sort(vec![col("a")])?
+ .limit(0, Some(10))?
+ .build()?;
+
+ // Should push down limit to sort
+ let expected = "Limit: skip=0, fetch=10\
+ \n Sort: #test.a, fetch=10\
+ \n TableScan: test";
+
+ assert_optimized_plan_eq(&plan, expected);
+
+ Ok(())
+ }
+
+ #[test]
+ fn limit_push_down_sort_skip() -> Result<()> {
+ let table_scan = test_table_scan()?;
+
+ let plan = LogicalPlanBuilder::from(table_scan)
+ .sort(vec![col("a")])?
+ .limit(5, Some(10))?
+ .build()?;
+
+ // Should push down limit to sort
+ let expected = "Limit: skip=5, fetch=10\
+ \n Sort: #test.a, fetch=15\
+ \n TableScan: test";
+
+ assert_optimized_plan_eq(&plan, expected);
+
+ Ok(())
+ }
+
Review Comment:
Yes - otherwise TableScan and other nodes would have the limit pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
