drin commented on code in PR #14071:
URL: https://github.com/apache/arrow/pull/14071#discussion_r976956799
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -94,6 +94,20 @@ Status CheckRelCommon(const RelMessage& rel) {
return Status::OK();
}
+// Other helper functions
+Status DiscoverFilesFromDir(std::shared_ptr<fs::LocalFileSystem>& local_fs,
+ std::string dirpath, std::vector<fs::FileInfo>&
rel_fpaths) {
+ // Define a selector for a recursive descent
+ fs::FileSelector selector;
+ selector.base_dir = dirpath;
+ selector.recursive = true;
+
+ ARROW_ASSIGN_OR_RAISE(auto file_infos, local_fs->GetFileInfo(selector));
+ std::move(file_infos.begin(), file_infos.end(),
std::back_inserter(rel_fpaths));
Review Comment:
I think Weston must have misunderstood me then. I had code for omitting
subdirectories, so I can just put that back in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
