zeroshade commented on code in PR #14179:
URL: https://github.com/apache/arrow/pull/14179#discussion_r978935989
##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -526,6 +526,14 @@ class RecordBatchSerializer {
return VisitType(*array.indices());
}
+ Status Visit(const RunLengthEncodedArray& array) {
+ --max_recursion_depth_;
+ RETURN_NOT_OK(VisitArray(*array.run_ends_array()));
+ RETURN_NOT_OK(VisitArray(*array.values_array()));
+ ++max_recursion_depth_;
+ return Status::OK();
+ }
Review Comment:
nvm, i see the usage of `logical_run_ends` and `logical_values`, but
shouldn't this be using those instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
