vibhatha commented on code in PR #14186: URL: https://github.com/apache/arrow/pull/14186#discussion_r979144342
########## cpp/src/arrow/engine/substrait/util.h: ########## @@ -25,6 +25,8 @@ #include "arrow/engine/substrait/options.h" #include "arrow/util/iterator.h" +#include "substrait/algebra.pb.h" // IWYU pragma: export Review Comment: This part is not very sure. We could include proto headers which is required for this, but what is the best practice here? Since there would be more utils like this which could reference the interfaces in the `algebra.pb.h`, we could use it. But as per this PR what is the best? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
