tustvold commented on code in PR #3386:
URL: https://github.com/apache/arrow-datafusion/pull/3386#discussion_r979432068
##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -543,22 +559,22 @@ impl SortPreservingMergeStream {
}
}
- loop {
- // NB timer records time taken on drop, so there are no
- // calls to `timer.done()` below.
- let elapsed_compute =
self.tracking_metrics.elapsed_compute().clone();
- let _timer = elapsed_compute.timer();
+ // NB timer records time taken on drop, so there are no
+ // calls to `timer.done()` below.
+ let elapsed_compute = self.tracking_metrics.elapsed_compute().clone();
Review Comment:
Yes, which turned out to be a major bottleneck, as Instant::now is a syscall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
