assignUser commented on code in PR #14202:
URL: https://github.com/apache/arrow/pull/14202#discussion_r979791575
##########
r/configure:
##########
@@ -184,8 +184,8 @@ else
# Use pkg-config to do static linking of libarrow's dependencies
if [ "$ARROW_DEPENDENCY_SOURCE" = "AUTO" ] || [
"$ARROW_DEPENDENCY_SOURCE" = "SYSTEM" ]; then
- PKG_LIBS="`PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config
--libs-only-l --static --silence-errors ${PKG_CONFIG_NAME}`"
- PKG_LIBS="$PKG_LIBS `PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config
--libs-only-other --static --silence-errors ${PKG_CONFIG_NAME}`"
+ export
PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}
+ PKG_LIBS="`pkg-config --libs --static --silence-errors
${PKG_CONFIG_NAME}`"
Review Comment:
These changes are not required for configure.win because we use the mysys
stuff anyway right?
##########
dev/tasks/r/github.packages.yml:
##########
@@ -324,6 +329,7 @@ jobs:
env:
LIBARROW_BINARY: "FALSE"
ARROW_R_DEV: "TRUE"
+ CMAKE_FIND_DEBUG_MODE: "ON"
Review Comment:
Should we remove this before merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
