tustvold commented on code in PR #2781:
URL: https://github.com/apache/arrow-rs/pull/2781#discussion_r980407193
##########
arrow-buffer/src/bigint.rs:
##########
@@ -0,0 +1,253 @@
+use num::BigInt;
+use std::cmp::Ordering;
+
+/// A signed 256-bit integer
+#[allow(non_camel_case_types)]
+#[derive(Copy, Clone, Default, Eq, PartialEq, Hash)]
+pub struct i256([u8; 32]);
+
+impl std::fmt::Debug for i256 {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "{}", self)
+ }
+}
+
+impl std::fmt::Display for i256 {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "{}", BigInt::from_signed_bytes_le(&self.0))
+ }
+}
+
+impl PartialOrd for i256 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ Some(self.cmp(other))
+ }
+}
+
+impl Ord for i256 {
+ fn cmp(&self, other: &Self) -> Ordering {
Review Comment:
This is related to #2360, performing the comparison this way is
significantly faster than using memcmp, which is itself significantly faster
than using BigInt.
FYI @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
