kou commented on code in PR #14202:
URL: https://github.com/apache/arrow/pull/14202#discussion_r980516180
##########
dev/tasks/r/github.packages.yml:
##########
@@ -324,6 +329,7 @@ jobs:
env:
LIBARROW_BINARY: "FALSE"
ARROW_R_DEV: "TRUE"
+ CMAKE_FIND_DEBUG_MODE: "ON"
Review Comment:
I want to keep this to debug a problem in the future.
This step is executed only when the above build step is failed. Is it
accepted?
##########
r/configure:
##########
@@ -184,8 +184,8 @@ else
# Use pkg-config to do static linking of libarrow's dependencies
if [ "$ARROW_DEPENDENCY_SOURCE" = "AUTO" ] || [
"$ARROW_DEPENDENCY_SOURCE" = "SYSTEM" ]; then
- PKG_LIBS="`PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config
--libs-only-l --static --silence-errors ${PKG_CONFIG_NAME}`"
- PKG_LIBS="$PKG_LIBS `PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config
--libs-only-other --static --silence-errors ${PKG_CONFIG_NAME}`"
+ export
PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}
+ PKG_LIBS="`pkg-config --libs --static --silence-errors
${PKG_CONFIG_NAME}`"
Review Comment:
I didn't see `configure.win` but it seems that `configure.win` doesn't use
`pkg-config` on release build. `configure.win` uses `pkg-config` on dev build
but it already uses `pkg-config --libs ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
