js8544 commented on code in PR #14242:
URL: https://github.com/apache/arrow/pull/14242#discussion_r982573498
##########
cpp/src/arrow/json/parser.cc:
##########
@@ -102,7 +104,7 @@ Status Kind::ForType(const DataType& type, Kind::type*
kind) {
Status Visit(const BinaryType&) { return SetKind(Kind::kString); }
Status Visit(const LargeBinaryType&) { return SetKind(Kind::kString); }
Status Visit(const TimestampType&) { return SetKind(Kind::kString); }
- Status Visit(const FixedSizeBinaryType&) { return SetKind(Kind::kString); }
+ Status Visit(const FixedSizeBinaryType&) { return
SetKind(Kind::kNumberOrString); }
Review Comment:
changed to Decimal
##########
cpp/src/arrow/json/parser.cc:
##########
@@ -504,6 +514,9 @@ class RawBuilderSet {
}
return Status::OK();
}
+ case Kind::kNumberOrString: {
+ return Cast<Kind::kNumberOrString>(builder)->AppendNull();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
