liukun4515 commented on code in PR #3636:
URL: https://github.com/apache/arrow-datafusion/pull/3636#discussion_r982967336
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -119,6 +134,41 @@ impl ExprRewriter for TypeCoercionRewriter {
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
match expr {
+ Expr::ScalarSubquery(Subquery { subquery }) => {
+ let mut optimizer_config = OptimizerConfig::new();
Review Comment:
After we move the `type coercion` out of the optimizer framework, we don't
need the parameter of `OptimizerConfig` to iterate the plan when doing the type
coercion.
I think the `new` of `OptimizerConfig` will not affect the rule of `type
coercion`, because the rule of `type coercion` don't use the `OptimizerConfig`
to generate some values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
