thisisnic commented on code in PR #14030:
URL: https://github.com/apache/arrow/pull/14030#discussion_r983315400
##########
r/R/util.R:
##########
@@ -134,12 +134,7 @@ read_compressed_error <- function(e) {
stop(e)
}
-# This function was refactored in ARROW-15260 to only raise an error if
-# the appropriate string was found and so errors must be raised manually after
-# calling this if matching error not found
-# TODO: Refactor as part of ARROW-17355 to prevent potential missed errors
-handle_parquet_io_error <- function(e, format, call) {
- msg <- conditionMessage(e)
+handle_parquet_io_error <- function(msg, call, format) {
Review Comment:
My concern here is that this error can be triggered both in the case we test
for - the user omits a format specification - and also in the case that they
are trying to read from a corrupted Parquet file. If the latter is true, the
additional message is not actually helpful and may be misleading. The
additional message coming second helps frame it as a suggestion rather than as
the definitive solution to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
