lidavidm commented on code in PR #14244:
URL: https://github.com/apache/arrow/pull/14244#discussion_r983592131
##########
java/vector/src/main/codegen/templates/DenseUnionVector.java:
##########
@@ -940,4 +940,13 @@ public void setInitialCapacity(int valueCount, double
density) {
}
}
}
+
+ /**
+ * Set the element at the given index to null. For DenseUnionVector, it is a
no-op as nulls are not supported at the
+ * top level, and isNull() always returns false. Nullability is only handled
at the level of individual child vectors.
Review Comment:
The writer API is a separate API, isn't it? Why do they have to be tied?
For sparse union vectors, by definition all the vectors would need to
contain some value. So I don't see the issue in delegating. For dense union
vectors, only one would need a value, and an offset would be appended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
