tustvold opened a new pull request, #2809:
URL: https://github.com/apache/arrow-rs/pull/2809
_Draft as currently SIMD fails to compile due to Float16 support_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Uses some macro trickery to allow arbitrary numbers of arrays in
downcast_primitive_array. Not only is this potentially useful, it reduces code
duplication and yields better consistency. Unfortunately this consistency is
back-firing slightly, as support for Float16 SIMD arithmetic is not
implemented, and this was just left out of the macro :sweat_smile:
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Float16Array will be downcast in the binary invocation, this probably counts
as an API change
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
