liukun4515 commented on code in PR #3662: URL: https://github.com/apache/arrow-datafusion/pull/3662#discussion_r984517465
########## datafusion/optimizer/src/unwrap_cast_in_comparison.rs: ########## @@ -15,8 +15,9 @@ // specific language governing permissions and limitations // under the License. -//! Pre-cast literal binary comparison rule can be only used to the binary comparison expr. -//! It can reduce adding the `Expr::Cast` to the expr instead of adding the `Expr::Cast` to literal expr. +//! Unwrap-cast binary comparison rule can be used to the binary/inlist comparison expr now, and other type +//! of expr can be added if needed. +//! This rule can reduce adding the `Expr::Cast` the expr instead of adding the `Expr::Cast` to literal expr. Review Comment: Thanks for your comments @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org