askoa commented on code in PR #3669:
URL: https://github.com/apache/arrow-datafusion/pull/3669#discussion_r985080659
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -1458,11 +1552,15 @@ mod tests {
// ----- Simplifier tests -------
// ------------------------------
- fn simplify(expr: Expr) -> Expr {
+ fn simplify_result(expr: Expr) -> Result<Expr> {
let schema = expr_test_schema();
let execution_props = ExecutionProps::new();
let info = SimplifyContext::new(vec![&schema], &execution_props);
- expr.simplify(&info).unwrap()
+ expr.simplify(&info)
+ }
+
+ fn simplify(expr: Expr) -> Expr {
Review Comment:
Cool! How do we know what's the error message for
`Err(DataFusionError::ArrowError(ArrowError::DivideByZero))` ?
Edit: NVM I got it. Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
