maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500243584
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -53,8 +53,19 @@ class BaseTestStringKernels : public ::testing::Test {
std::shared_ptr<DataType> offset_type() {
return TypeTraits<OffsetType>::type_singleton();
}
+ std::shared_ptr<DataType> list_type();
};
+template <>
+std::shared_ptr<DataType> BaseTestStringKernels<LargeStringType>::list_type() {
+ return large_list(this->type());
Review comment:
because it may have a lot of elements, leading to a long list. But you
are right, all cases are possible, e.g. a large string with just a few really
large elements, or a normal string that will split into more elements.
Any idea what to do? this made the most sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
