ZMZ91 commented on code in PR #14073:
URL: https://github.com/apache/arrow/pull/14073#discussion_r990876084
##########
cpp/src/gandiva/gdv_function_stubs.cc:
##########
@@ -825,6 +831,11 @@ void ExportedStubFunctions::AddMappings(Engine* engine)
const {
engine->AddGlobalMappingForFunc("gdv_fn_random_with_seed",
types->double_type(), args,
reinterpret_cast<void*>(gdv_fn_random_with_seed));
+ args = {types->i64_type(), types->i64_type(), types->i1_type()};
+ engine->AddGlobalMappingForFunc("gdv_fn_random_with_seed_int64",
types->double_type(),
Review Comment:
Do you mean remove the int32 one and only support int64? I see the gdv
registry is quite restrict. Say the "add" function, it takes "add_int8_int8",
"add_int16_int16", "add_int32_int32" ... to support different param types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
