pitrou commented on code in PR #14359:
URL: https://github.com/apache/arrow/pull/14359#discussion_r991287728
##########
cpp/src/parquet/encoding.h:
##########
@@ -394,6 +394,12 @@ class DictDecoder : virtual public TypedDecoder<DType> {
// ----------------------------------------------------------------------
// TypedEncoder specializations, traits, and factory functions
+class BooleanDecoder : virtual public TypedDecoder<BooleanType> {
+ public:
+ using TypedDecoder<BooleanType>::Decode;
+ virtual int Decode(uint8_t* buffer, int max_values) = 0;
Review Comment:
Can you add a docstring? It should be clear that `buffer` will contain
bit-packed values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
