rtpsw commented on PR #14386: URL: https://github.com/apache/arrow/pull/14386#issuecomment-1276240482
> (but let's not silently truncate output columns either). Before coding the condition `if (static_cast<size_t>(schema->num_fields()) > values.size())` with `>` I tried coding it with `!=` but got test failures elsewhere: ``` [ RUN ] ExecPlanExecution.StressSourceOrderBy /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/compute/exec/plan_test.cc:739: Failure Failed '_error_or_value56.status()' failed with Invalid: mismatching schema size Google Test trace: /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/compute/exec/plan_test.cc:720: single threaded /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/compute/exec/plan_test.cc:717: unslowed [ FAILED ] ExecPlanExecution.StressSourceOrderBy (1 ms) ``` and ``` [ RUN ] Substrait.BasicPlanRoundTrippingEndToEnd /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/compute/exec/exec_plan.cc:58: Plan was destroyed before finishing /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/engine/substrait/serde_test.cc:2083: Failure Failed '_error_or_value131.status()' failed with Invalid: mismatching schema size [ FAILED ] Substrait.BasicPlanRoundTrippingEndToEnd (1 ms) ``` If we'd like to fix these test failures, I'd suggest doing so separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
