alamb commented on code in PR #3822:
URL: https://github.com/apache/arrow-datafusion/pull/3822#discussion_r996292693
##########
datafusion/core/src/physical_plan/file_format/mod.rs:
##########
@@ -698,6 +699,7 @@ mod tests {
projection,
statistics,
table_partition_cols,
+ config_options: ConfigOptions::new().into_shareable(),
Review Comment:
I agree it is non obvious -- `ConfigOptions` was changed to be shareable by
@waitingkuo in https://github.com/apache/arrow-datafusion/pull/3455
Basically the usecase there was so that the configuration was owned by
`SessionContext` but other parts could read it if necessary -- specifically,
`information_schema.df_settings` / `SHOW ALL` initially. This PR extends the
concept so that the settings can be read by the parquet reader
What would you think about moving the mutability handling into
`ConfigOption` so this looks like
```rust
config_options: ConfigOptions::new(),
```
That would hide the details of shared ownership more nicely I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
