mingmwang commented on code in PR #3855:
URL: https://github.com/apache/arrow-datafusion/pull/3855#discussion_r998923548
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -68,7 +68,7 @@ fn build_gcs_object_store(url: &Url) -> Result<Arc<dyn
object_store::ObjectStore
let host = get_host_name(url)?;
let mut builder = GoogleCloudStorageBuilder::new().with_bucket_name(host);
- if let Some(path) = env::var("GCP_SERVICE_ACCOUNT_PATH").ok() {
+ if let Ok(path) = env::var("GCP_SERVICE_ACCOUNT_PATH") {
Review Comment:
Yes, they are suggested by the clippy, so I have to change accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
