isidentical commented on code in PR #3889:
URL: https://github.com/apache/arrow-datafusion/pull/3889#discussion_r999432821
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -98,6 +98,10 @@ struct DataFusionBenchmarkOpt {
/// Path to output directory where JSON summary file should be written to
#[structopt(parse(from_os_str), short = "o", long = "output")]
output_path: Option<PathBuf>,
+
+ /// Whether to disable collection of statistics (and cost based
optimizations) or not.
+ #[structopt(short = "S", long = "disable-statistics")]
Review Comment:
I was also thinking about it but then decided against it since the default
is already `true`. Do you know whether we have any places where we continuously
run benchmarks where making the default `false` would change results? If it
wouldn't cause a regression on places where we compare benchmarks across
datafusion commits/versions, I think it should be an easy to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
