avantgardnerio commented on code in PR #403:
URL: https://github.com/apache/arrow-ballista/pull/403#discussion_r1000798779


##########
dev/docker/ballista-scheduler.Dockerfile:
##########
@@ -24,7 +24,16 @@ ENV RUST_LOG=info
 ENV RUST_BACKTRACE=full
 ENV DEBIAN_FRONTEND=noninteractive
 
-RUN apt-get update && apt-get install -y nginx netcat
+RUN apt-get update &&\
+    apt-get install -y nginx netcat nodejs npm
+    
+COPY ballista/ui /root/ballista/ui
+
+RUN cd /root/ballista/ui/scheduler &&\

Review Comment:
   Also, having a `.sh` script is discriminating against windows users, who run 
a different terminal altogether for some reason. Unless they choose to run 
`msys`, `cigwin`, `wsl1`, `wsl2`, `git bash`, `winbash`, or `colinux`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to