wjones127 commented on code in PR #14018:
URL: https://github.com/apache/arrow/pull/14018#discussion_r1002198768
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -180,6 +184,33 @@ class PARQUET_EXPORT FileReader {
virtual ::arrow::Status GetRecordBatchReader(
const std::vector<int>& row_group_indices, const std::vector<int>&
column_indices,
std::unique_ptr<::arrow::RecordBatchReader>* out) = 0;
+ ::arrow::Status GetRecordBatchReader(const std::vector<int>&
row_group_indices,
+ const std::vector<int>& column_indices,
+
std::shared_ptr<::arrow::RecordBatchReader>* out);
+
+ /// \brief Return a RecordBatchReader of row groups selected from
+ /// row_group_indices, whose columns are selected by column_indices.
+ ///
+ /// \param row_group_indices indices of which row groups to include.
+ /// \param column_indices indices of columns to include.
+ ///
+ /// \since 10.0.0
+ ::arrow::Result<std::shared_ptr<::arrow::RecordBatchReader>>
GetRecordBatchReader(
Review Comment:
I decided to revert my changes creating result-returning APIs. Because we
have both `unique_ptr` and `shared_ptr` variants, it seemed easiest to keep
these APIs as they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
