maxburke commented on code in PR #3911:
URL: https://github.com/apache/arrow-datafusion/pull/3911#discussion_r1002322920
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -1187,6 +1187,7 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
Value::LargeBinaryValue(s.to_owned())
})
}
+ scalar::ScalarValue::FixedSizeBinary(_, _) => todo!(),
Review Comment:
Done. The error type in to_proto doesn't have the NotImplented variant as it
isn't a DataFusionError, hopefully a string saying that it isn't implemented is
sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
