rtpsw commented on code in PR #14485:
URL: https://github.com/apache/arrow/pull/14485#discussion_r1003180495
##########
cpp/src/arrow/engine/substrait/test_plan_builder.cc:
##########
@@ -88,16 +91,18 @@ Result<std::unique_ptr<substrait::ProjectRel>>
CreateProject(
// If it doesn't have a type then it's an enum
const std::string& enum_value = arguments[arg_index];
auto enum_ = std::make_unique<substrait::FunctionArgument::Enum>();
- if (enum_value.size() > 0) {
- enum_->set_specified(enum_value);
- } else {
- auto unspecified = std::make_unique<google::protobuf::Empty>();
- enum_->set_allocated_unspecified(unspecified.release());
- }
+ enum_->set_specified(enum_value);
Review Comment:
This change seems unintended.
##########
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##########
@@ -76,7 +75,7 @@ static void TableJoinOverhead(benchmark::State& state,
for (auto _ : state) {
state.PauseTiming();
ASSERT_OK_AND_ASSIGN(std::shared_ptr<arrow::compute::ExecPlan> plan,
- ExecPlan::Make(&ctx));
+ ExecPlan::Make());
Review Comment:
This line and similar ones seem like an unintended change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
