tustvold commented on code in PR #3950:
URL: https://github.com/apache/arrow-datafusion/pull/3950#discussion_r1004873121


##########
docs/source/contributor-guide/index.md:
##########
@@ -44,6 +44,28 @@ git-bash.exe
 cargo build
 ```
 
+## Protoc Installation
+
+Compiling DataFusion from sources requires an installed version of the 
protobuf compiler, `protoc`.
+
+On most platforms this can be installed from your system's package manager
+
+```
+$ apt install -y protobuf-compiler
+$ dnf install -y protobuf-compiler
+$ pacman -S protobuf-compiler
+$ brew install protobuf
+```
+
+You will want to verify the version installed is `3.12` or greater, which 
introduced support for explicit [field 
presence](https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md).
 Older versions may fail to compile.

Review Comment:
   DataFusion doesn't actually use this feature, for good reason imo, but this 
is the only major functionality change to the core protoc functionality that 
may cause compatibility issues for us. More importantly 3.12 is the version 
currently used in CI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to