tustvold commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1005156169


##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
                 RowSelector::select(2),
                 RowSelector::skip(1),
                 RowSelector::select(1),
-                RowSelector::skip(4)
+                RowSelector::skip(4),
             ]
         );
     }
 
+    #[test]
+    fn test_and_2() {

Review Comment:
   Yes, as per the doc comment, and_then is for computing the resulting 
RowSelection when the provided RowSelection is the result of the computation 
"under" another. We can, and probably should add a separate `and` for combining 
together row selections



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to