assignUser commented on code in PR #14501:
URL: https://github.com/apache/arrow/pull/14501#discussion_r1005572477
##########
dev/archery/archery/docker/core.py:
##########
@@ -342,7 +342,8 @@ def run(self, service_name, command=None, *, env=None,
volumes=None,
# append env variables from the compose conf
for k, v in service.get('environment', {}).items():
- args.extend(['-e', '{}={}'.format(k, v)])
+ if v is not None:
+ args.extend(['-e', '{}={}'.format(k, v)])
Review Comment:
archery already gets the enclosing env vars:
https://github.com/apache/arrow/blob/master/dev/archery/archery/docker/core.py#L81
so no need to do it manually here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
