emkornfield commented on code in PR #14142:
URL: https://github.com/apache/arrow/pull/14142#discussion_r1006113011
##########
cpp/src/parquet/column_reader_test.cc:
##########
@@ -572,5 +576,615 @@ TEST_F(TestPrimitiveReader,
TestNonDictionaryEncodedPagesWithExposeEncoding) {
pages_.clear();
}
+// Tests reading a repeated field using the RecordReader.
+TEST(RecordReaderTest, BasicReadRepeatedField) {
+ internal::LevelInfo level_info;
+ level_info.def_level = 1;
+ level_info.rep_level = 1;
+
+ NodePtr type = schema::Int32("b", Repetition::OPTIONAL);
+ const ColumnDescriptor descr(type, level_info.def_level,
level_info.rep_level);
+
+ // Records look like: {[10], [20, 20], [30, 30, 30]}
+ std::vector<std::shared_ptr<Page>> pages;
+ std::vector<int32_t> values = {10, 20, 20, 30, 30, 30};
+ std::vector<int16_t> def_levels = {1, 1, 1, 1, 1, 1};
+ std::vector<int16_t> rep_levels = {0, 0, 1, 0, 1, 1};
+
+ std::unique_ptr<PageReader> pager;
+ std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
+ &descr, values, /*num_values=*/static_cast<int>(def_levels.size()),
Encoding::PLAIN,
+ /*indices=*/{},
+ /*indices_size=*/0, def_levels, level_info.def_level, rep_levels,
+ level_info.rep_level);
+ pages.push_back(std::move(page));
+ pager.reset(new test::MockPageReader(pages));
Review Comment:
@fatemehp looks like you missed addressing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
