retikulum commented on issue #3152: URL: https://github.com/apache/arrow-datafusion/issues/3152#issuecomment-1292678101
> > In which file we should implement as_int32_array function? I have implemented it in datafusion\common\src\lib.rs but I am not quite sure about the architecture. > > I think that is reasonable. Or perhaps something like `datafusion\common\src\cast.rs` ? `datafusion\common\src\cast.rs` is my first idea but I just don't want to create a new file :) cast fits better. > > Before opening pr, I want to be sure that this sample is implemented correctly. I added this function: > > Thanks @retikulum -- that looks good to me > > What I would suggest is doing this in a series of smaller PRs -- perhaps add a few functions like `as_int32_array`, `as_uint32_array`, etc and consolidate some of the uses. > > That way we can then get feedback from the wider community before you spend a large amount of your time changing the entire codebase This is exactly what I planned. Moreover, I will not get lost in the ocean. Thanks for feedback @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
