lwhite1 commented on code in PR #14506: URL: https://github.com/apache/arrow/pull/14506#discussion_r1006870367
########## java/c/src/main/java/org/apache/arrow/c/CDataArrayHandle.java: ########## @@ -0,0 +1,40 @@ +package org.apache.arrow.c; + +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.memory.ForeignAllocationManager; + +/** Manage the reference count of an imported C Data ArrowArray. */ Review Comment: Looks good, but I'm a bit concerned that the class name and the fact that it does not implement ReferenceManager obscures the fact that it does reference counting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
