nealrichardson opened a new pull request, #14553: URL: https://github.com/apache/arrow/pull/14553
Most places where the bindings code was using `build_expr()` were unnecessary because they were unary functions so there are no types to align. `cast` was a big part of this. The few remaining uses of build_expr are things like arithmetic, `if_else`, etc. There is one behavior change as a result of this refactor: when the input is a Scalar (or R vector turned into a Scalar), the casting happens on the Scalar eagerly, not lazily as an Expression. This only affected a few datetime tests for bad input. I believe there is a little more refactoring left to do to pull out some special cases from `build_expr` but this is almost there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
