alamb commented on code in PR #4084:
URL: https://github.com/apache/arrow-datafusion/pull/4084#discussion_r1011996812
##########
datafusion/common/src/dfschema.rs:
##########
@@ -596,6 +596,18 @@ mod tests {
use arrow::datatypes::DataType;
use std::collections::BTreeMap;
+ #[test]
+ fn qualifier_in_name() -> Result<()> {
+ let schema = DFSchema::try_from_qualified_schema("t1",
&test_schema_1())?;
+ // lookup with unqualified name "t1.c0"
+ let err = schema.index_of_column_by_name(None, "t1.c0").err().unwrap();
+ assert_eq!(
+ "Schema error: No field named 't1.c0'. Valid fields are 't1'.'c0',
't1'.'c1'.",
Review Comment:
looks a lot better to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
