viirya commented on code in PR #3010:
URL: https://github.com/apache/arrow-rs/pull/3010#discussion_r1013283672
##########
arrow-schema/src/field.rs:
##########
@@ -200,12 +200,12 @@ impl Field {
/// within `self` contained within this field (including `self`)
pub(crate) fn fields(&self) -> Vec<&Field> {
let mut collected_fields = vec![self];
- collected_fields.append(&mut self._fields(&self.data_type));
+ collected_fields.append(&mut Field::_fields(&self.data_type));
collected_fields
}
- fn _fields<'a>(&'a self, dt: &'a DataType) -> Vec<&Field> {
+ fn _fields(dt: &DataType) -> Vec<&Field> {
Review Comment:
error: parameter is only used in recursion
##########
arrow/src/ipc/convert.rs:
##########
@@ -477,7 +477,6 @@ pub(crate) fn build_field<'a>(
/// Get the IPC type of a data type
pub(crate) fn get_fb_field_type<'a>(
data_type: &DataType,
- is_nullable: bool,
Review Comment:
error: parameter is only used in recursion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
