avantgardnerio commented on issue #4106: URL: https://github.com/apache/arrow-datafusion/issues/4106#issuecomment-1305852365
> never live in the area that has the timezone switch @waitingkuo I think this is good advice :) Hopefully the US ends this nonsense next year. I find it troubling that postgres happily parses ambiguous timestamps and chooses a default arbitrarily, but it seems like the emerging trend for DataFusion is "just do what postgres does", so perhaps we just copy their flawed implementation. What's even more troubling than it defaulting an ambiguous timestamp is that it happily parses a non-existent `2:30AM` in March! I guess the only real choice we have is: 1. do we follow postgres' arguably flawed behavior? 2. or do we throw errors for ambiguous/invalid timestamps? Finally, I even wonder how chrono deals with all this? DST didn't always start or end in March/November, so a database is required to keep track of when various legal jurisdictions implement/modify/retract DST. In unix-based OSes I think this is a tzinfo file, but I know of no equivalent on Windows. If we do embrace `US/MT`, I think we should account for the [historical shifts](https://en.wikipedia.org/wiki/Daylight_saving_time_in_the_United_States#:~:text=By%20the%20Energy%20Policy%20Act,the%20first%20Sunday%20of%20November.) i.e. we need tests for April < 1986 rather than March. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
